Skip to content

[vertx-web] need a mechanism to override the behaviour (JSON) without changing the handler definition #9726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

klalit
Copy link

@klalit klalit commented Jun 8, 2021

No description provided.

@wing328
Copy link
Member

wing328 commented Jun 9, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@klalit
Copy link
Author

klalit commented Jun 9, 2021

@wing328 thank you for letting me know, fixed it

@wing328
Copy link
Member

wing328 commented Jun 17, 2021

Please follow item 3 in the PR checklist to update the samples: https://github.com/OpenAPITools/openapi-generator/blob/master/.github/PULL_REQUEST_TEMPLATE.md so that the CI can test the change.

@wing328
Copy link
Member

wing328 commented Jun 17, 2021

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@wing328 wing328 changed the title https://github.com/OpenAPITools/openapi-generator/issues/9725 [vertx-web] need a mechanism to override the behaviour (json) without changing the handler definition Jun 17, 2021
@wing328 wing328 changed the title [vertx-web] need a mechanism to override the behaviour (json) without changing the handler definition [vertx-web] need a mechanism to override the behaviour (JSON) without changing the handler definition Jun 17, 2021
@klalit
Copy link
Author

klalit commented Jun 17, 2021

@wing328 I followed the steps as indicated.

I checked "continuous-integration/appveyor/pr " but it is failing for csharp project, it does not seem to be related to the code change done in JavaVertWeb template or is it? please guide.

@klalit
Copy link
Author

klalit commented Jun 26, 2021

@wing328 Please let me know if something is breaking because of this PR, i doubt the change has to do anything with dot net where it is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants